Remove statement that default_icon is mandatory#43928
Merged
Conversation
default_icon is not mandatory. Firefox shows the default puzzle piece icon when default_icon is omitted
github-actions
Bot
added
Content:WebExt
Contributor
|
Preview URLs (1 page) External URLs (3)URL: |
rebloor
approved these changes
Apr 27, 2026
Contributor
rebloor
left a comment
rebloor
left a comment
There was a problem hiding this comment.
Thanks for spotting that @MeAmAnUsername
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
default_icon is not mandatory.
Motivation
Statement is incorrect
Additional details
It is noted as optional on the dedicated documentation page: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/page_action#default_icon
Firefox shows the default puzzle piece icon when default_icon is omitted. Tested in 149.0.2 (64-bit) on NixOS.
Related issues and pull requests
N.A.