fix(svg): clarify feOffset filter units example#44148
Merged
chrisdavidmills merged 1 commit intoMay 18, 2026
Merged
Conversation
danyalahmed1995
requested review from
chrisdavidmills
and removed request for
a team
Contributor
|
Preview URLs (1 page) |
chrisdavidmills
approved these changes
May 18, 2026
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
OK, that seems to make more sense conceptually, although it doesn't seem to make any difference to the rendering whatsoever. Thanks, @danyalahmed1995
Contributor
Author
|
@chrisdavidmills Yeah basically, this just makes it more clear to beginners and they won't confuse it with user space units. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
filterUnits="userSpaceOnUse"to the<feOffset>example filter so thewidthandheightvalues are interpreted as user-space units.Details
The current example uses:
Without an explicit
filterUnits, the default isobjectBoundingBox, sowidthandheightare interpreted relative to the bounding box rather than as user-space dimensions.This update makes the example match the apparent intent and avoids teaching readers that bare numeric filter dimensions behave like pixel/user-space values by default.
Fixes #44122.