Update index.md: refer to 'column' and fix solution#44267
Merged
Conversation
The instructions referred to setting the row width, which doesn't make sense. I think it should be column width. Also the solution set the row width to 20% which doesn't make sense.
github-actions
Bot
added
Content:Learn
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-05-28 11:15:27) |
chrisdavidmills
requested changes
May 27, 2026
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
Looks good, thank you for the fix, @yassam! I've got a few suggestions for improving the grammar of the note. Once you've applied these, you might also need to adjust the length of the lines so that they sit well together.
…or_scheme_search/index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…or_scheme_search/index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…or_scheme_search/index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…or_scheme_search/index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Adjust comment line lengths
Contributor
Author
|
Thanks @chrisdavidmills! I've committed your suggestions and adjusted the comment line lengths |
chrisdavidmills
approved these changes
May 28, 2026
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
Awesome, this looks good; let's get it merged. Thanks again, @yassam!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The instructions referred to setting row widths, which doesn't make sense. I think it should be column widths.
Also the solution set row widths to 20% which doesn't make sense.
I don't think it's necessary to explicitly set the default column width to 20%. All we need to do is explicitly set the 4th column to 40%, and the others will get the remaining 60% distributed to them equally (20% each to the other 3 columns).
Motivation
The instructions are confusing, i.e. referring to rows rather than columns. Part of the solution looks wrong i.e. setting a
trwidth of 20% (I removed this).Additional details
Related issues and pull requests