Conversation
Gregoor
requested review from
a team,
fiji-flo and
peterbe
and removed request for
a team
peterbe
left a comment
peterbe
left a comment
There was a problem hiding this comment.
I always get nervous about that.
get-diff-action uses minimatch and in their example they have a + before the list of file extensions.
As mentioned in Slack, I think you should include a silly change to file/en-us/mdn/kitchensink/index.html and make sure that file gets built.
|
Looks like I am pinging people to review left-and-right automatically, because the system thinks I am a stranger. Sorry @Rumyra! |
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs |
| id: git_diff_content | ||
| with: | ||
| PATTERNS: files/**/*.html | ||
| PATTERNS: files/**/*.+(html|md) |
There was a problem hiding this comment.
Yay! There are so many ways and I can never remember which is which. Apparently, this here works.
peterbe
left a comment
peterbe
left a comment
There was a problem hiding this comment.
Would you mind doing another commit + push where you remove the sample change in the kitchensink page?
Co-authored-by: Peter Bengtsson <mail@peterbe.com>
|
Done! Thanks for the hint @peterbe. Shall we merge? |
3 participants
Hey @peterbe,
I have to admit that I did not try to run this locally (most of all, because I did not know how). My intention here is to make preview work for getting #5193 into shape. Lmkwyt!