Skip to content

Array some: Inconsistent Parameter Name #8550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wbamberg merged 1 commit into from
Sep 2, 2021
Merged

Array some: Inconsistent Parameter Name #8550

wbamberg merged 1 commit into from
Sep 2, 2021

Conversation

@renomureza
Copy link
Contributor

@renomureza renomureza commented Sep 2, 2021 •
edited
Loading

What was wrong/why is this fix needed? (quick summary only)

In the syntax it says callbackFn, but in the parameter description it says callback: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some

@renomureza
Array some: Inconsistent Parameter Name
3bbfa42 
In the syntax it says callbackFn, but in the parameter description it says callback.
@renomureza renomureza requested a review from a team as a code owner September 2, 2021 03:23
@renomureza renomureza requested review from sideshowbarker and removed request for a team September 2, 2021 03:23
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some
Title: Array.prototype.some()
on GitHub

No new external URLs

wbamberg
wbamberg approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@wbamberg wbamberg merged commit 993efa6 into mdn:main Sep 2, 2021
@renomureza renomureza deleted the array-some branch September 2, 2021 03:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wbamberg wbamberg wbamberg approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@renomureza @wbamberg