Skip to content

Conversation

@alvestrand
Copy link
Contributor

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'

What was wrong/why is this fix needed? (quick summary only)

This was missing in docs, it's listed on https://w3c.github.io/webrtc-pc/#rtcsignalingstate-enum and implemented.

Anything else that could help us review it

Example of confusion caused by this error:

https://bugs.chromium.org/p/chromium/issues/detail?id=1245777&

This was missing in docs, it's listed on https://w3c.github.io/webrtc-pc/#rtcsignalingstate-enum and implemented.
@alvestrand alvestrand requested a review from a team as a code owner September 2, 2021 06:59
@alvestrand alvestrand requested review from sideshowbarker and removed request for a team September 2, 2021 06:59
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/API/RTCPeerConnection/signalingState
Title: RTCPeerConnection.signalingState
on GitHub
Flaw count: 2

  • macros:
    • Unknown macro domref
  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC

External URLs

URL: /en-US/docs/Web/API/RTCPeerConnection/signalingState
Title: RTCPeerConnection.signalingState
on GitHub

No new external URLs

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teoli2003 teoli2003 merged commit addb260 into mdn:main Sep 2, 2021
@teoli2003
Copy link
Contributor

Thanks a lot!

Looks good to me.

Congratulations upon your first merged commit here! Welcome aboard! 🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants