Skip to content

Conversation

@TurekBot
Copy link
Contributor

@TurekBot TurekBot commented Sep 10, 2021

This PR is in regard to the Sending and retrieving form data article, section "Other languages and frameworks" https://developer.mozilla.org/en-US/docs/Learn/Forms/Sending_and_retrieving_form_data#other_languages_and_frameworks

It seems to make sense to include a framework for Java since it's one of the most used languages in the world currently and is often taught in schools.

Spring has a quick-start tutorial specifically about handling form submission which seems like a really good fit.

Let me know if there's anything you'd like changed!

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'

Not an issue, just an improvement.

What was wrong/why is this fix needed? (quick summary only)

My addition includes a server-side framework for Java because it's a very popular language.

Anything else that could help us review it

Nope!

It seems to make sense to include a framework for Java since it's the most used language in the world currently and is often taught in schools. 

Spring has a quick-start tutorial specifically about handling form submission which seems like a really good fit.
@TurekBot TurekBot requested a review from a team as a code owner September 10, 2021 18:54
@TurekBot TurekBot requested review from teoli2003 and removed request for a team September 10, 2021 18:54
@teoli2003 teoli2003 removed their request for review September 10, 2021 18:58
@teoli2003
Copy link
Contributor

I think we should remove all external links from this list. It is very subjective and unmaintainable. We can add a sentence about the existence of dozens of solutions besides the one with guides on MDN.

What do you think @Rumyra, @wbamberg

@wbamberg
Copy link
Collaborator

You mean, keep the links to Django and Express (since we are already endorsing these to the (much greater) extent of writing guides to them) and remove the others, just replacing them with a general statement that lots of alternatives exist? I think that's a good idea.

@teoli2003
Copy link
Contributor

Yes, that is what I meant.

@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Learn/Forms/Sending_and_retrieving_form_data
Title: Sending form data
on GitHub
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Attributes/action
    • Can't resolve /en-US/docs/Web/HTML/Attributes/method
    • Link points to the page it's already on

External URLs

URL: /en-US/docs/Learn/Forms/Sending_and_retrieving_form_data
Title: Sending form data
on GitHub

@hamishwillee
Copy link
Collaborator

I don't particularly agree that these links are a problem (given the frameworks are all popular and long lived, and so are their links). I guess it does reduce ongoing maintenance due to the fact we'll always be missing someone's favourite framework.

@TurekBot
Copy link
Contributor Author

I agree that the list should not continually be added to. Everyone's favorite framework shouldn't make the list.

Perhaps the intended audience of the article can guide the decision of which frameworks it would be helpful to include links to.

@teoli2003 teoli2003 added the Content:Learn Learning area docs label Sep 13, 2021
@Rumyra
Copy link
Collaborator

Rumyra commented Sep 13, 2021

In the contexts of this page, I think adding one Java framework is ok. I do think however this should not be an extensive list moving forward. One example of all the top server side language frameworks gives the learner an overview into what to expect if they carry on learning in this area.

The discussion on external links can be done outside of this PR (I think this will need some very clear guidelines).

I'll merge this and then start making some notes on what we expect from external links :)

@Rumyra Rumyra merged commit 804fdab into mdn:main Sep 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Content:Learn Learning area docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants