Skip to content

Change background color in example of Child combinator page#9324

Merged
wbamberg merged 2 commits intomdn:mainfrom
digi-booster:patch-71
Sep 28, 2021
Merged

Change background color in example of Child combinator page#9324
wbamberg merged 2 commits intomdn:mainfrom
digi-booster:patch-71

Conversation

@digi-booster
Copy link
Copy Markdown
Contributor

@digi-booster digi-booster commented Sep 28, 2021 •
edited
Loading 

 span {
  background-color: white;
}

changing with

/* Instead of using the default value, a different value should be used in the background color to demonstrate the example. */
 span {
  background-color: aqua;
}

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'

What was wrong/why is this fix needed? (quick summary only)

Anything else that could help us review it

@digi-booster
Change background color in example of Child combinator page
99afda9 
```css
 span {
  background-color: white;
}
```
change into
```css
// Instead of using the default value, a different value should be used in the background color to demonstrate the example.
 span {
  background-color: red;
}
```
@digi-booster digi-booster requested a review from a team as a code owner September 28, 2021 17:08
@digi-booster digi-booster requested review from rachelandrew and removed request for a team September 28, 2021 17:08
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Sep 28, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 28, 2021 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/CSS/Child_combinator
Title: Child combinator
on GitHub

No new external URLs

(this comment was updated 2021-09-28 17:13:03.749119)

wbamberg
wbamberg approved these changes Sep 28, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me, thanks @digi-booster !

@wbamberg wbamberg merged commit 229fd7d into mdn:main Sep 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wbamberg wbamberg wbamberg approved these changes

@rachelandrew rachelandrew Awaiting requested review from rachelandrew

Assignees

No one assigned

Labels

Content:CSS Cascading Style Sheets docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@digi-booster @wbamberg