Skip to content

title of a few elements missing context in the title#9637

Merged
Elchi3 merged 12 commits intomainfrom
estelle-patch-1
Nov 22, 2021
Merged

title of a few elements missing context in the title#9637
Elchi3 merged 12 commits intomainfrom
estelle-patch-1

Conversation

@estelle
Copy link
Copy Markdown
Member

@estelle estelle commented Oct 7, 2021

the title was just <wbr>. Pages like td have titles like " <td> the table celll element

the title was just `<wbr>`. Pages like `td` have titles like " `<td>` the table celll element
@estelle estelle requested a review from a team as a code owner October 7, 2021 00:54
@estelle estelle requested review from ericwbailey and removed request for a team October 7, 2021 00:54
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Oct 7, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/HTML/Element/data
Title: <data>: The Data element
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/wbr
Title: <wbr>: The Line Break Opportunity element
on GitHub

No new external URLs

(this comment was updated 2021-11-22 09:12:55.071544)

@estelle estelle changed the title title of wbr element title of a few elements missing context in the title Oct 7, 2021
Copy link
Copy Markdown
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for #9634, the title needs to be quoted (single quotes for consistency), presumably because it contains ":" which upsets the YAML parser.

@estelle
Copy link
Copy Markdown
Member Author

estelle commented Oct 13, 2021

not sure how i let you know changes were made, but changes were made ;)
cc: @wbamberg

Copy link
Copy Markdown
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Since we use single-quotes in titles for all the other ones (that I could see) can we use single quotes for these as well?

Copy link
Copy Markdown
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to single quotes

@Elchi3 Elchi3 enabled auto-merge (squash) November 22, 2021 09:13
@Elchi3 Elchi3 dismissed wbamberg’s stale review November 22, 2021 09:13

comment addressed

@Elchi3 Elchi3 merged commit c69a238 into main Nov 22, 2021
@Elchi3 Elchi3 deleted the estelle-patch-1 branch November 22, 2021 09:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Content:HTML Hypertext Markup Language docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants