Skip to content

feat(css): Update syntax for <generic-family>#952

Merged
dipikabh merged 1 commit intomdn:mainfrom
skyclouds2001:generic-family
Mar 28, 2025
Merged

feat(css): Update syntax for <generic-family>#952
dipikabh merged 1 commit intomdn:mainfrom
skyclouds2001:generic-family

Conversation

@skyclouds2001
Copy link
Contributor

Description

the <generic-family> is used by font-family, update it to match the latest spec and browser implement:

split <generic-family> into <generic-complete> and <generic-incomplete>, add support for non-standatd emoji and fangsong value

also remove the <generic-name> type which is never used

Motivation

https://drafts.csswg.org/css-fonts/#propdef-font-family

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review March 26, 2025 03:49
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner March 26, 2025 03:49
@skyclouds2001 skyclouds2001 requested review from dipikabh and removed request for a team March 26, 2025 03:49
@otomad
Copy link

otomad commented Mar 26, 2025

Actually I still don't know how to use <generic-script-specific> and generic() function in font-family, it doesn't seem to work.

e.g. generic(fangsong) generic(kai) generic(khmer-mul) generic(nastaliq).

@skyclouds2001
Copy link
Contributor Author

Actually I still don't know how to use <generic-script-specific> and generic() function in font-family, it doesn't seem to work.

e.g. generic(fangsong) generic(kai) generic(khmer-mul) generic(nastaliq).

These are not added because they are not supported by any platform at present

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@dipikabh dipikabh merged commit 1fd7137 into mdn:main Mar 28, 2025
1 check passed
@skyclouds2001 skyclouds2001 deleted the generic-family branch March 29, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments