-
Notifications
You must be signed in to change notification settings - Fork 1.9k
3rd attempt at trying to push view transition types examples #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3rd attempt at trying to push view transition types examples #367
Conversation
pepelsbey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you :)
A few suggestions:
-
“MPA transition types example” and “MPA multiple transition types example” book demos look and behave identically but achieve it slightly differently. I would maybe highlight it in the folder’s index?
-
For the same book demo: I would add chapter names to subpage titles to make it clear that we’re navigating between pages: “Chapter 1 — Table of contents MPA view transition types”, etc.
-
Maybe we should use README.md for index pages? They are rendered to HTML. For example:
fetch/README.mdturns into https://mdn.github.io/dom-examples/fetch/ — this will make them easier to maintain.
All done. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
| <ol> | ||
| <li><a href="index.html">Introduction</a></li> | ||
| <li>Chapter 1</li> | ||
| <li><a href="index3.html">Chapter 2</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <li><a href="index3.html">Chapter 2</a></li> | |
| <li><a href="index3.html">Chapter 2</a></li> |
Ouch, I just realized that naming in the demo is a bit confusing: Chapter 2 goes to index3.html.
I'm absolutely nitpicking here, but it would be nice to have a structure like that:
- index.html (Intro)
- chapter1.html
- chapter2.html
- etc.
I hope it won't be too much work to organize it little better. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the latest commit. I've updated the page titles so the pages are now "Chapter 1" to "Chapter 5" and removed the "Introduction" title, so the numbers match up.
I don't want to start changing the file names, as my JS logic relies on them, and that would be even more work to fix. I think this works.
…dmills/dom-examples into view-transition-types-attempt3
pepelsbey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you :)
|
Thanks so much, @pepelsbey, much appreciated. |
I am currently working on documenting view transition types; this PR adds three examples that demonstrate various aspects of the feature.
I also took this opportunity to add an index page for the view transitions demos, and link to that instead from the readme file, thereby cleaning it up a bit and making them easier to navigate.