Skip to content

Conversation

@chrisdavidmills
Copy link
Contributor

I am currently working on documenting view transition types; this PR adds three examples that demonstrate various aspects of the feature.

I also took this opportunity to add an index page for the view transitions demos, and link to that instead from the readme file, thereby cleaning it up a bit and making them easier to navigate.

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner November 28, 2025 14:46
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

A few suggestions:

  • “MPA transition types example” and “MPA multiple transition types example” book demos look and behave identically but achieve it slightly differently. I would maybe highlight it in the folder’s index?

  • For the same book demo: I would add chapter names to subpage titles to make it clear that we’re navigating between pages: “Chapter 1 — Table of contents MPA view transition types”, etc.

  • Maybe we should use README.md for index pages? They are rendered to HTML. For example: fetch/README.md turns into https://mdn.github.io/dom-examples/fetch/ — this will make them easier to maintain.

@chrisdavidmills
Copy link
Contributor Author

Looks good! Thank you :)

A few suggestions:

* “MPA transition types example” and “MPA multiple transition types example” book demos look and behave identically but achieve it slightly differently. I would maybe highlight it in the folder’s index?

* For the same book demo: I would add chapter names to subpage titles to make it clear that we’re navigating between pages: “Chapter 1 — Table of contents MPA view transition types”, etc.

* Maybe we should use README.md for index pages? They are rendered to HTML. For example: `fetch/README.md` turns into https://mdn.github.io/dom-examples/fetch/ — this will make them easier to maintain.

All done.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

This pull request has merge conflicts that must be resolved before it can be merged.

<ol>
<li><a href="index.html">Introduction</a></li>
<li>Chapter 1</li>
<li><a href="index3.html">Chapter 2</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><a href="index3.html">Chapter 2</a></li>
<li><a href="index3.html">Chapter 2</a></li>

Ouch, I just realized that naming in the demo is a bit confusing: Chapter 2 goes to index3.html.

I'm absolutely nitpicking here, but it would be nice to have a structure like that:

  • index.html (Intro)
  • chapter1.html
  • chapter2.html
  • etc.

I hope it won't be too much work to organize it little better. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the latest commit. I've updated the page titles so the pages are now "Chapter 1" to "Chapter 5" and removed the "Introduction" title, so the numbers match up.

I don't want to start changing the file names, as my JS logic relies on them, and that would be even more work to fix. I think this works.

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you :)

@pepelsbey pepelsbey merged commit 1da7c80 into mdn:main Dec 4, 2025
1 check passed
@chrisdavidmills chrisdavidmills deleted the view-transition-types-attempt3 branch December 4, 2025 08:24
@chrisdavidmills
Copy link
Contributor Author

Thanks so much, @pepelsbey, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants