feat(bcd): render links to JSON in simplified HTML#1502
Merged
Conversation
Contributor
|
207dbc6 was deployed to: https://fred-pr1502.review.mdn.allizom.net/ |
caugner
approved these changes
Apr 21, 2026
| import { HeadingAnchor } from "../heading-anchor/server.js"; | ||
| import { ServerComponent } from "../server/index.js"; | ||
|
|
||
| export class BCDSection extends ServerComponent { |
Contributor
There was a problem hiding this comment.
nit: For consistency with CompatTable, consider renaming to CompatSection.
| ? nothing | ||
| : HeadingAnchor.render(2, id ? String(id) : null, String(title))} | ||
| <a | ||
| href="${BCD_BASE_URL}/bcd/api/v0/current/${query}.json" |
Contributor
There was a problem hiding this comment.
nit: Should we generate this URL with a util function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BCD sections are currently empty in the simplified HTML: this extracts the BCD section into its own server component, and renders a link to the JSON when in simplified mode.