-
Notifications
You must be signed in to change notification settings - Fork 44
feat(l10n): extract strings, add docs, load locales on demand #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
40e0960
chore(l10n): move fluent files
LeoMcA 23d5342
chore(l10n): load locales on demand
LeoMcA 82e1a3b
chore(l10n): require l10n tags to have an id
LeoMcA f38b6c8
fix(l10n): don't return html type from l10n template tag
LeoMcA 3903375
chore(l10n): add string scraper/extractor script
LeoMcA 8407f21
chore(l10n): add lint mode to extractor
LeoMcA 3245e89
chore(l10n): add generated qa locale
LeoMcA 538881a
chore(l10n): add docs
LeoMcA f30f28b
chore(l10n): script to generate missing ids
LeoMcA 82dcb10
run l10n:extract
LeoMcA ea56bde
run scripts/migrate-l10n/index.js
LeoMcA b5974db
run prettier
LeoMcA 3dba163
run l10n:extract
LeoMcA 153f4db
chore(l10n): remove script to generate missing ids
LeoMcA a1fe237
extract.js -> cli.js
LeoMcA 1e27dbf
add comments to explain pseudo-locales better
LeoMcA 0a17c28
add --gen-pseudo option to l10n script
LeoMcA 992ecd9
explain why we check if localizedStringOrHtml is a string
LeoMcA 2f2d567
move warning to constant
LeoMcA e5e897d
split up extractor function and add unit tests
LeoMcA b6c47ad
add newline to end of file
LeoMcA 1b57f8d
move locale loading on the client into a hook
LeoMcA 662edc0
add --help to l10n cli
LeoMcA b7641d0
EDIT_WARNING -> TEMPLATE_HEADER; update references to generator
LeoMcA 9b3e8fc
add newline
LeoMcA 8d9a454
Revert "run prettier"
LeoMcA ae6fe33
Revert "run scripts/migrate-l10n/index.js"
LeoMcA ebb592e
Merge remote-tracking branch 'origin/main' into fluent-ast
LeoMcA 103fd7d
revert unnecessary lets to consts
LeoMcA 652560b
chore(l10n): script to generate missing ids
LeoMcA df84148
run scripts/migrate-l10n/index.js
LeoMcA eb31d2a
run prettier
LeoMcA 9f70f9e
regenerate template.ftl
LeoMcA 52c589b
Remove components/left-sidebar/inline.js
LeoMcA e402016
Revert "chore(l10n): script to generate missing ids"
LeoMcA 1f3ec40
don't shadow path import
LeoMcA 7df3367
fail on duplicated scraped ids with different text
LeoMcA 08e3ce4
fail on duplicated ids with different text across manual and scraped …
LeoMcA 446cf83
fix duplicates
LeoMcA d9aedcd
remove duplicates where ids and text match from template.ftl
LeoMcA 5dea7c4
add l10n lint to lefthook
LeoMcA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given how fast this runs, should we not also run it on pre-commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
globoption supports multiple values, so we could run it only when relevant files were changed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure case is something like: