This repository was archived by the owner on Jun 21, 2022. It is now read-only.
Merged
Conversation
Contributor
Author
|
The context for this is to be able to use the Document JSON API and get that identifier out. The Document JSON API has a key which is the rendered body HTML which we can parse and pick apart. |
Elchi3
reviewed
Sep 24, 2019
Elchi3
reviewed
Sep 24, 2019
Contributor
Author
|
I tested this manually now. In Kuma and sure enough it's there: <div class="bc-data" id="bcd:html.elements.details"> |
escattone
approved these changes
Sep 25, 2019
Contributor
Author
|
FYI @escattone perhaps we should set up that thing we have in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1238
I just made the change without knowing how to test this in
kuma. Also, I don't know ifidentifieris the right string :)But the goal is to be able to do something like this:
and that should print the identifier that is equivalent to what we put in the front-matter of https://github.com/mdn/stumptown-content/blob/master/content/html/reference/elements/video/docs.md
PS. I don't know how to write and run unit tests for KS.