This repository was archived by the owner on Jun 21, 2022. It is now read-only.
removing the webgl content from the learning area sidebar, and adding…#999
Merged
wbamberg merged 1 commit intomdn:masterfrom Feb 7, 2019
Merged
Conversation
… it to the WebGL sidebar instead
Contributor
Author
|
Can I please get a review on this PR, and get it merged? The Learning Area has been sat there with a broken link on its sidebar for over 2 months now, and it has been reported to me about 30 times. Thanks ;-) |
wbamberg
approved these changes
Feb 7, 2019
wbamberg
left a comment
wbamberg
left a comment
There was a problem hiding this comment.
I've looked at the update, and checked that the sidebars look OK in a local Kuma, and that the generated HTML is valid according to the W3C validator.
Contributor
Author
|
Thanks @wbamberg, you are a lifesaver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… it to the WebGL sidebar instead
So I decided to remove the WebGL content from the Learning area; see the description on this page for why: https://developer.mozilla.org/en-US/docs/Learn/WebGL
The "learn by example" articles are still useful, so I've moved them into the WebGL section: https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/By_example
This PR accounts for that move in the sidebars for those docs trees.