fix(issues): identify source for sidebar link issues#641
Merged
Conversation
When a sidebar produces a broken, redirected, or ill-cased link, the issue message now says `Sidebar <name>` instead of `Macro ?`. This is achieved by adding a `sidebar` tracing span, and extracting it alongside `templ` via the new `source_label` helper.
Contributor
|
3bade1c was deployed to: https://rari-pr641.review.mdn.allizom.net/ |
LeoMcA
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Identify the source for sidebar links issues.
Motivation
Make it easy to understand where the issue comes from, i.e. how to fix it.
Additional details
When a sidebar produces a broken, redirected, or ill-cased link, the issue message now says
Sidebar <name>instead ofMacro ?.Related issues and pull requests
Triggered by mdn/content#43843 (comment).