add in different theme images#294
Merged
wbamberg merged 1 commit intomdn:masterfrom Oct 6, 2017
andymckay:dark-theme-icon
Merged
add in different theme images#294wbamberg merged 1 commit intomdn:masterfrom andymckay:dark-theme-icon
wbamberg merged 1 commit intomdn:masterfrom
andymckay:dark-theme-icon
Conversation
Author
|
|
|
This is nice, but testing in Nightly and 57, I see the light icon with the default theme, which looks weird because the toolbar is light in the default theme. Do you see that too? Is it intentional? |
Author
|
Ah I think that's https://bugzilla.mozilla.org/show_bug.cgi?id=1404568. |
wbamberg
reviewed
Oct 6, 2017
tabs-tabs-tabs/manifest.json
Outdated
| }, | ||
| "background": { | ||
| "scripts": ["background.js"] | ||
| } |
There was a problem hiding this comment.
Is the change to this file intentional? It doesn't look related and there's no description of it.
Author
There was a problem hiding this comment.
Totally accident. Will remove.
wbamberg
suggested changes
Oct 6, 2017
wbamberg
left a comment
wbamberg
left a comment
There was a problem hiding this comment.
Is the change to tabs-tabs-tabs/manifest.json intentional, and if so, what is it for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an example of https://bugzilla.mozilla.org/show_bug.cgi?id=1329242