chore(auto-merge): remove target-repo input#190
Conversation
Callers should prevent fork execution themselves.
LeoMcA
left a comment
LeoMcA
left a comment
There was a problem hiding this comment.
Looks good, but a couple of questions: non-blocking if the answer is "no".
| with: | ||
| auto-merge: true | ||
| secrets: | ||
| GH_TOKEN: ${{ secrets.AUTOMERGE_TOKEN }} |
There was a problem hiding this comment.
Remind me why we have to set permissions: contents: read and GH_TOKEN, is it just a temporary migration thing, or separation of concerns (contents: read is the implicit permissions the workflow gets to check out the repo, GH_TOKEN is what's used to merge the PR? Perhaps that should be documented
There was a problem hiding this comment.
Eventually, the contents: read permission should allow us to checkout private repositories if the workflow runs in that repository.
To achieve this, we first need to add contents: read in all calling workflow(s), and only then can we request the permission in the composable workflow, or else it will fail.
There was a problem hiding this comment.
Ok, would be nice to explain that in docs/auto-merge.md once we've completed the migration
3 participants
Description
Update the
auto-mergeworkflow, removing the obsoletetarget-repoinput.Motivation
Callers are meanwhile passing
{{ github.repository }}as value, and instead prevent execution in forks viaif: github.repository_owner == 'mdn', so this is no longer needed.Additional details
Related issues and pull requests
Related to mdn/fred#1395.