Skip to content

moment calculation#40

Merged
A-CGray merged 2 commits intomainfrom
moment-ref
Jan 19, 2026
Merged

moment calculation#40
A-CGray merged 2 commits intomainfrom
moment-ref

Conversation

@gawng
Copy link
Copy Markdown
Collaborator

@gawng gawng commented Jan 18, 2026

Purpose

feat: expose xref to aeroproblem level but keep defaults if user does not set it.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gawng gawng requested a review from a team as a code owner January 18, 2026 16:22
@gawng gawng requested a review from A-CGray January 18, 2026 16:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.78%. Comparing base (6a08ccc) to head (8d6025a).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   66.43%   66.78%   +0.35%     
==========================================
  Files           4        4              
  Lines         569      575       +6     
==========================================
+ Hits          378      384       +6     
  Misses        191      191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@A-CGray A-CGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@A-CGray A-CGray merged commit a60b2d1 into main Jan 19, 2026
9 checks passed
@A-CGray A-CGray deleted the moment-ref branch January 19, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants