Skip to content

Update abs complex safe routine for numpy2#13

Merged
A-CGray merged 4 commits intomainfrom
fix-numpy2
Mar 2, 2026
Merged

Update abs complex safe routine for numpy2#13
A-CGray merged 4 commits intomainfrom
fix-numpy2

Conversation

@eirikurj
Copy link
Copy Markdown
Collaborator

@eirikurj eirikurj commented Mar 2, 2026

Purpose

The numpy.sign function changes its behavior with numpy2. This fix adds support for numpy2 and recovers previous behavior.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner March 2, 2026 14:45
@A-CGray A-CGray merged commit bc4fd56 into main Mar 2, 2026
8 checks passed
@A-CGray A-CGray deleted the fix-numpy2 branch March 2, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants