Skip to content

Test cs function with negative values#14

Merged
eirikurj merged 3 commits intomainfrom
testImprovement
Mar 2, 2026
Merged

Test cs function with negative values#14
eirikurj merged 3 commits intomainfrom
testImprovement

Conversation

@A-CGray
Copy link
Copy Markdown
Member

@A-CGray A-CGray commented Mar 2, 2026

Purpose

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner March 2, 2026 18:14
@A-CGray A-CGray requested a review from eirikurj March 2, 2026 18:14
eirikurj
eirikurj previously approved these changes Mar 2, 2026
@eirikurj
Copy link
Copy Markdown
Collaborator

eirikurj commented Mar 2, 2026

Looks good, just some formatting issues

@eirikurj
Copy link
Copy Markdown
Collaborator

eirikurj commented Mar 2, 2026

also maybe remove the numpy2 check here since its not needed

if np.__version__[0] == "2":

@eirikurj eirikurj merged commit dee9447 into main Mar 2, 2026
8 checks passed
@eirikurj eirikurj deleted the testImprovement branch March 2, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants