Skip to content

Conversation

@A-CGray
Copy link
Member

@A-CGray A-CGray commented Jul 3, 2025

Purpose

Expected time until merged

A.S.A.P, this fix is holding up mdolab/sphinx_mdolab_theme#17, which is in turn holding up many PRs across several repos

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Tested docs build locally before and after the fix

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner July 3, 2025 14:31
@A-CGray A-CGray requested review from eirikurj, gawng and sseraj July 3, 2025 14:31
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.64%. Comparing base (045775d) to head (628e1b2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files           4        4           
  Lines         538      538           
=======================================
  Hits          450      450           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A-CGray
Copy link
Member Author

A-CGray commented Jul 3, 2025

The docs build will continue to fail until we merge mdolab/sphinx_mdolab_theme#17, which depends on this PR

Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't merge this, but it looks good

@eirikurj
Copy link
Contributor

eirikurj commented Jul 3, 2025

I can merge this

@eirikurj eirikurj merged commit 781b6b9 into main Jul 3, 2025
11 of 12 checks passed
@eirikurj eirikurj deleted the docFix branch July 3, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants