Skip to content

Conversation

@eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Sep 9, 2024

Purpose

Per title. imp has been removed in python 3.12.

Expected time until merged

Once tests pass.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

We currently dont run or test python 3.12, but if anyone has it installed, please test.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner September 9, 2024 16:32
@eirikurj eirikurj requested review from gawng and lamkina September 9, 2024 16:32
@codecov
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.24%. Comparing base (303a221) to head (ccc7a7a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyhyp/MExt.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   79.24%   79.24%           
=======================================
  Files           4        4           
  Lines         424      424           
=======================================
  Hits          336      336           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gawng gawng merged commit a161009 into main Sep 24, 2024
@ewu63 ewu63 deleted the updateMExt branch September 24, 2024 16:45
DavidAnderegg added a commit to anilyil/pyhyp that referenced this pull request Sep 26, 2024
updating MExt to support python 3.12 (mdolab#95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants