A11y improvment (part 1)

[basile-parent]

First part of the improvments proposed in #544 :

• removing the "radio" attribute on buttons when it's not relevant
• properly grouping the relevant radio button

The only thing I could not do is to translate the new locale entry to all languages

[petyosi]

Thank you for the PR.

The project has prettier configured, but for some reason, your PR uses a different formatting which results in a massive change - this makes it very hard for me to review it; the build won't pass as well.

Can you fix the formatting? I don't think that the change you mean to introduce should change 300+lines.

[basile-parent]

Yeah, I don't know why it don't apply... I'll fix that and push a new commit

[basile-parent]

@petyosi I think we are good now

[petyosi]

The current state of the PR has typescript failing and hooks with missing dependencies. Also, it changes the spacing of the toolbar, making it wider:

[basile-parent]

The missing imports were so weird... It should have worked at all 🤔 Anyway, it's fixed.

I also fixed the spacing but had to make some compromises to have the exact same render : I had to externalize the <div className={styles.toolbarGroupOfGroups}>. If not, there are additional margins on the sup/sub formatting (only difference).
If you think this difference is acceptable, I can rollback this change.

[dartilesm]

Is this PR going to be merged at some point? Seems interesting

[petyosi]

No, unfortunately not. The changes are too complex and, as far as I remember, some of the problems I outlined are still there. Closing.

[basile-parent]

No, unfortunately not. The changes are too complex and, as far as I remember, some of the problems I outlined are still there. Closing.

Hello @petyosi, I think I have solved all the problems you outlined. What can I do to be more compliant ? You says the changes are too complex : if you have an idea to make it simplier, I'm open to suggestions.

As for now, the component has some accessibility failure whose are important to fix if we want to continue to use it. In France, a new law will be applied on June 28th : accessibility compliance will be mandatory for (almost) all companies.

[petyosi]

Thanks for the update on the France laws - this is important of course, not only for compliance purposes.

However, I can't merge this - it changes the style of the toolbar, and it adds a bunch of modifications to the toolbar primitives which don't seem obvious. The hook problem is also still there:

I don't want to block you on the necessary changes, so my advice would be to fork and publish your own version. I hope I will be able to get to prioritizing the accessibility compliance of the component, but this is a large task.