Add overlayContainer prop so overlay location can be controlled. #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter can control in which HTML element the popup containers are shown. This enables the usage of MDXEditor within <dialog> HTML elements. mdx-editor#752
Contributor
|
This looks good, I will test it the next few days and merge if everything is ok. |
|
🎉 This PR is included in version 3.30.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
Thank you for the quick review and release! 🎉❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Enables setting the overlayContainer on MDXEditor so the implementer can control in which HTML element the popup containers are shown. This enables the usage of MDXEditor within HTML elements.
See #752