Update toolbar.tsx to remove dublicate tooltips in toggles icons #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing the title being passed to ToolbarToggleItem and keep the one passed to TooltipWrap to show only one tooltip
Update toolbar.tsx to remove dublicate tooltips in toggles icons
Contributor
|
Thanks, squashed that with another release. |
Author
|
hey, im on the last release updated 2 days ago , the issue persists |
Contributor
|
@aghimohamad I published a v3.30.1 a few hours ago. https://github.com/mdx-editor/editor/releases/tag/v3.30.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the bold/italic/underline toggles , both ToolbarToggleItem and TooltipWrap has the title being passed, resulting in both the tooltip from redux + the native html tooltip
Image example:
