Fix custom loader example #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code uglier, unfortunately, but the example provided here is incorrect. Since all the code is indented by 4 spaces, it is treated by the markdown parser as a code block, and you end up seeing the exports in the file inside of a formatted code block. Eliminating the extra indentation fixes this.
|
This pull request is automatically deployed with Now. |
Member
|
Whoops 😬. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code uglier, unfortunately, but the example provided here in the docs is incorrect (I found this out the hard way).
Since all the code here is indented by 4 spaces, it is treated by the markdown parser as a code block, and you end up seeing the exports in the file inside of a formatted code block. Eliminating the extra indentation fixes this.