Convert node.meta to undefined if null #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattdamon108 described the following warning being printed into the browser's console:
This issue was supposed to have been fixed on #294, but a change on c26a03d#diff-fd729e637d80469ad8fcafd812c97b44 changed the value of
props.metastringtonode.meta(a value created by mdast), which, by looking at the specification, will benullinstead ofundefinedif no meta string is present after the language.mdast Code specification
I haven't checked the React source, but it is probably complaining because it doesn't know how to convert a
nullprop into a DOM attribute value.