Pass exports to Layout #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
johno
reviewed
Jan 23, 2019
packages/mdx/mdx-hast-to-jsx.js
Outdated
| ${layout ? `Layout={this.layout} layoutProps={props}` : ''} | ||
| ${ | ||
| layout | ||
| ? `Layout={this.layout} layoutProps={{ ...layoutProps, ...props }}` |
Member
There was a problem hiding this comment.
I think we might need to tweak this to use Object.assign or configure buble to polyfill:
Suggested change
| ? `Layout={this.layout} layoutProps={{ ...layoutProps, ...props }}` | |
| ? `Layout={this.layout} layoutProps={Object.assign(layoutProps, props)}` |
|
Is this functionality documented anywhere? As the PR isn't that clear on how to make use of it. |
johno
pushed a commit
that referenced
this pull request
Feb 18, 2019
* Pass exports to Layout Closes #378 * Use Object.assign
Contributor
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #378