Skip to content

Improve missing props for mdxType #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Improve missing props for mdxType #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/react/src/create-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ const MDXCreateElement = ({
}
MDXCreateElement.displayName = 'MDXCreateElement'

export default function(type, props = {}) {
export default function(type, props) {
const args = arguments
const mdxType = props && props.mdxType

if (typeof type === 'string' || props.mdxType) {
if (typeof type === 'string' || mdxType) {
const argsLength = args.length

const createElementArgArray = new Array(argsLength)
Expand All @@ -44,7 +45,7 @@ export default function(type, props = {}) {
}
}
newProps.originalType = type
newProps[TYPE_PROP_NAME] = typeof type === 'string' ? type : props.mdxType
newProps[TYPE_PROP_NAME] = typeof type === 'string' ? type : mdxType

createElementArgArray[1] = newProps

Expand Down