Skip to content

Use a Set for shortcode names #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2019
Merged

Use a Set for shortcode names #522

merged 2 commits into from
Apr 12, 2019

Conversation

@chasemccoy
Copy link
Contributor

@chasemccoy chasemccoy commented Apr 12, 2019

Fixes #518

@vercel
Copy link

vercel bot commented Apr 12, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://mdx-git-fork-chasemccoy-patch-1.mdx.now.sh

@vercel vercel bot temporarily deployed to staging April 12, 2019 16:25 Inactive
@chasemccoy chasemccoy mentioned this pull request Apr 12, 2019
Closed
@vercel vercel bot temporarily deployed to staging April 12, 2019 16:31 Inactive
@ChristopherBiscardi
Copy link
Member

ChristopherBiscardi commented Apr 12, 2019

Dope! LGTM

Just waiting for tests to pass

johno
johno approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johno johno merged commit c220f4c into mdx-js:master Apr 12, 2019
@chasemccoy chasemccoy deleted the patch-1 branch April 12, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johno johno johno approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shortcodes breaks if same component if used more than once

3 participants

@chasemccoy @ChristopherBiscardi @johno