Only pass children to React.Fragment #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the default wrapper is a React Fragment we should ignore all props passed aside from children so it doesn't cause React to warn. --- Fixes #530
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://mdx-git-wrapper.mdx.now.sh |
wooorm
approved these changes
Apr 16, 2019
ChristopherBiscardi
approved these changes
Apr 16, 2019
Member
ChristopherBiscardi
left a comment
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
nice, this was a thing affecting gatsby-mdx users
Member
Author
|
Published as 1.0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the default wrapper is a React Fragment we
should ignore all props passed aside from children
so it doesn't cause React to warn.
Fixes #530