raw nodes should be labeled as element after conversion #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`raw` returns the root node type as `root`, which ends up causing double-processing issues. We swapped it to `jsx` to fix that, which ends up causing the converted HAST to get picked off before it can be processed into template strings, etc. The type should be `element` so that downstream processing happens appropriately.
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://mdx-git-fork-christopherbiscardi-raw.mdx.now.sh |
johno
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rawreturns the root node type asroot, which ends up causingdouble-processing issues. We swapped it to
jsxto fix that, which ends upcausing the converted HAST to get picked off before it can be processed into
template strings, etc. The type should be
elementso that downstreamprocessing happens appropriately.