This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Handle multiple WebSocket frames within a TCP packet#338
Merged
me-no-dev merged 1 commit intome-no-dev:masterfrom Jul 24, 2018
Merged
Handle multiple WebSocket frames within a TCP packet#338me-no-dev merged 1 commit intome-no-dev:masterfrom
me-no-dev merged 1 commit intome-no-dev:masterfrom
Conversation
Owner
|
Hey! Thanks for doing this! Really sorry that I have not had the time to take care of this repo recently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for handling multiple WebSocket frames within a TCP packet.
Have been encountering an issue on Chrome 64.0.3282.186 where WebSocket message requests are missing during initial page load. Typically when there are a number of HTTP requests in flight.
Can reproduce by having the browser buffer WebSocket frames before sending:
Expect: bunch of fragmented frames followed by 10 short messages
Actual: bunch of fragmented frames
Frames are silently discarded when the received frame length is no longer a function of the received packet size. This PR adds a loop and adjusts the length checks to take into account that multiple frames may exist within a TCP packet.