Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Fix compiler warnings for AsyncJson’s _contentLength/_maxContentLength vars#439

Merged
me-no-dev merged 2 commits intome-no-dev:masterfrom
buddydvd:AsyncJson_contentLength_type_fix
Jun 22, 2019
Merged

Fix compiler warnings for AsyncJson’s _contentLength/_maxContentLength vars#439
me-no-dev merged 2 commits intome-no-dev:masterfrom
buddydvd:AsyncJson_contentLength_type_fix

Conversation

@buddydvd
Copy link
Copy Markdown
Contributor

@buddydvd buddydvd commented Dec 4, 2018

This commit fixes the following compiler warning:

In file included from src/Program.cpp:21:0:
lib/ESPAsyncWebServer/src/AsyncJson.h: In member function 'virtual void AsyncCallbackJsonWebHandler::handleBody(AsyncWebServerRequest*, uint8_t*, size_t, size_t, size_t)':
lib/ESPAsyncWebServer/src/AsyncJson.h:153:64: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (total > 0 && request->_tempObject == NULL && total < _maxContentLength) {

The type of AsyncCallbackJsonWebHandler's member variables _contentLength and _maxContentLength should both be unsigned integer type size_t.

buddydvd and others added 2 commits December 4, 2018 15:04
…h vars

The type of _contentLength and _maxContentLength should both be unsigned
integer type size_t.
@me-no-dev
Copy link
Copy Markdown
Owner

better late than never i guess :D

@me-no-dev me-no-dev merged commit d55dd73 into me-no-dev:master Jun 22, 2019
DanielKnoop pushed a commit to DanielKnoop/ESPAsyncWebServer that referenced this pull request Jun 17, 2022
…h vars (me-no-dev#439)

The type of _contentLength and _maxContentLength should both be unsigned
integer type size_t.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants