Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a JSON Diff Viewer tool, featuring a React-based UI for side-by-side comparisons and a utility for calculating structural differences in JSON data. The implementation includes support for identifying added, removed, and changed fields, along with comprehensive unit tests. Review feedback highlights opportunities to improve the user experience by handling empty inputs more gracefully, enhance maintainability by replacing magic numbers with constants, and simplify redundant logic in the path generation utility.
Owner
|
@naowas Please fix the code review issues. |
Author
Fixed all the review points |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR features a new JSON Diff Viewer tool that enables users to compare two JSON objects (Original vs. Modified) and see differences in a clear, human-readable format.
Included: