PascalCase property names #21
Conversation
|
Leaked my test token again 🙄 |
| Task<Uri> InitiateSSOLogin(string companyId, string returnUrl); | ||
| Task<Uri> GetSSOReturnUrl(string companyId); | ||
| Task<bool> CheckSSOEnabled(string CompanyId); | ||
| Task<Uri> InitiateSSOLogin(string CompanyId, string ReturnUrl); |
There was a problem hiding this comment.
As per Microsoft C# coding conventions https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/coding-conventions
Property names are PascalCase, while parameters and internal variables are camelCase
Task<Uri> InitiateSSOLogin(string companyId, string returnUrl);
| /// <summary> | ||
| /// "active" "inactive" | ||
| /// </summary> | ||
| public string? Status { get; set; } |
| [JsonPropertyName("comapnyId")] | ||
| public string ComapnyId { get; set; } |
There was a problem hiding this comment.
companyId has been renamed to accountAlias on the last Cryptlex WebAPI update
https://api.cryptlex.com/v3/docs#tag/Authentication/operation/post/v3/accounts/login/saml/verify
| public DateTime? CreatedAt { get; set; } | ||
| public DateTime? UpdatedAt { get; set; } | ||
| /// <summary> | ||
| /// "windows" "linux" "macOs" "android" "iOs" |
There was a problem hiding this comment.
It is lowercase
https://api.cryptlex.com/v3/docs#tag/Activations/operation/get/v3/activations/%7Bid%7D
"windows" "linux" "macos" "android" "ios"
| /// <summary> | ||
| /// "windows" "linux" "macOs" "android" "iOs" | ||
| /// </summary> | ||
| public string? Os { get; set; } |
There was a problem hiding this comment.
Same here, possible values are lowercase
https://api.cryptlex.com/v3/docs#tag/Activations/operation/get/v3/activations/%7Bid%7D
"windows" "linux" "macos" "android" "ios"
| [JsonPropertyName("os")] | ||
| public string Os { get; set; } |
There was a problem hiding this comment.
/// <summary>
/// Name of the operating sistem
/// Enum: "windows" "linux" "macos" "android" "ios"
/// </summary>
| [JsonPropertyName("os")] | ||
| public string Os { get; set; } |
There was a problem hiding this comment.
/// <summary>
/// Name of the operating system
/// Enum: "windows" "linux" "macos" "android" "ios"
/// </summary>
| [JsonPropertyName("@private")] | ||
| public bool? @private { get; set; } |
There was a problem hiding this comment.
Property name serialized should be string literal "private"
https://api.cryptlex.com/v3/docs#tag/Releases/operation/post/v3/releases
[JsonPropertyName("private")]
public bool? Private { get; set; }
| [JsonPropertyName("@private")] | ||
| public bool? @private { get; set; } |
There was a problem hiding this comment.
[JsonPropertyName("private")]
public bool? Private { get; set; }
| public string Body { get; set; } | ||
| [JsonPropertyName("replyTo")] | ||
| public string? ReplyTo { get; set; } | ||
| [JsonPropertyName("@event")] |
There was a problem hiding this comment.
[JsonPropertyName("event")]
public string Event{get;set;}
| public string? Body { get; set; } | ||
| [JsonPropertyName("replyTo")] | ||
| public string? ReplyTo { get; set; } | ||
| [JsonPropertyName("@event")] |
There was a problem hiding this comment.
[JsonPropertyName("event")
public string? Event{get;set;}
Thanks @dgvives!