Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ers-spec dependency source to use the meaningfy-ws/entity-resolution-spec Git repository (tracking develop), aligning the project with the ers-spec 0.3.0 line reflected in the lockfile.
Changes:
- Switched
ers-specGit URL fromOP-TEDtomeaningfy-wsinpyproject.toml. - Regenerated
poetry.lockto reflect the new Git source and resolved commit.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Updates ers-spec Git dependency URL to the meaningfy-ws repository. |
poetry.lock |
Updates the locked Git source URL and resolved_reference for ers-spec. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # TODO: should we have a registry? | ||
| ers-spec = { git = "https://github.com/OP-TED/entity-resolution-spec.git", branch = "develop" } | ||
| ers-spec = { git = "https://github.com/meaningfy-ws/entity-resolution-spec.git", branch = "develop" } |
There was a problem hiding this comment.
The ers-spec dependency is pinned to a moving develop branch. That makes installs non-reproducible (the same commit of this repo could resolve to different ers-spec code over time, especially when the lockfile isn’t used). Prefer pinning to an immutable reference (tag/version) or a specific commit rev and update the lock accordingly.
| ers-spec = { git = "https://github.com/meaningfy-ws/entity-resolution-spec.git", branch = "develop" } | |
| ers-spec = { git = "https://github.com/meaningfy-ws/entity-resolution-spec.git", rev = "CURRENT_ERS_SPEC_COMMIT_SHA" } |
|
No description provided.