Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

Enhancement logging app startup details#271

Merged
lirantal merged 5 commits into
meanjs:masterfrom
lirantal:enhancement-logging-app-startup-details
Nov 26, 2014
Merged

Enhancement logging app startup details#271
lirantal merged 5 commits into
meanjs:masterfrom
lirantal:enhancement-logging-app-startup-details

Conversation

@lirantal
Copy link
Copy Markdown
Member

Replacing the older console debug output with newer, more informative console debug output for application startup details.

Before:
meanjs-startup-old

After:
meanjs-startup-new

@lirantal
Copy link
Copy Markdown
Member Author

Do you think there's anything else we should push in terms of debug information when application starts?

@ilanbiala
Copy link
Copy Markdown
Member

You can probably remove the first chalk.inverse, because that is just saying what is printed below, no? Development is used a total of 3 times, I think the MEAN.JS can also just be MEAN.JS application started, because it says development more concisely right below.

@simison
Copy link
Copy Markdown
Contributor

simison commented Nov 20, 2014

https could be mentioned there?

@ilanbiala
Copy link
Copy Markdown
Member

+1 for HTTPS.

@lirantal
Copy link
Copy Markdown
Member Author

@ilanbiala I actually did remove the first white information text but it was in a commit after I took the screenshot and I didn't update the images :)

Good idea about the HTTPS. Any specific way how we want to show it?
Any other suggestions for things to show?

@lirantal
Copy link
Copy Markdown
Member Author

@ilanbiala oh also about the "MEAN.JS" text at the top - it's taking it from the 'title' configuration parameter which defaults to that text so in your own apps this should be more informative.

@simison
Copy link
Copy Markdown
Contributor

simison commented Nov 21, 2014

Something like "App running at https://localhost:3000" would combine three peaces of info into one. ;-)

@amoshaviv
Copy link
Copy Markdown
Contributor

Loving this! can it be merged to the new version as well?

@lirantal
Copy link
Copy Markdown
Member Author

yeah, I'll merge it there if required, after I make some of the changes proposed by @ilanbiala and @simison and then I'll merge it to current master as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants