This repository was archived by the owner on Aug 30, 2021. It is now read-only.
Refactor mongodb connection#289
Merged
Merged
Conversation
…rs for username and password
…ed connection string or others, and show an error
…ss to mongodb for some reason
Member
Author
Member
Author
|
@roieki @NeverOddOrEven what do you think? |
Member
Author
|
@Shrizzy @amoshaviv care to take a review here? it looks like a much needed change IMHO and I want to merge |
Member
There was a problem hiding this comment.
Why so many process URIs? In my opinion, let the user change the one included if necessary, but no need to include one for every database service.
Member
|
@lirantal other than the couple comments that I put, LGTM. The nice printout is definitely more useful, but all the process.env stuff and the options IMO is unnecessary. |
Member
Author
|
@ilanbiala thanks for reviewing, couple of comments:
|
Contributor
|
I just went over this for what it's worth. I like this change a lot! |
Member
Author
|
@NeverOddOrEven glad you liked it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring to mongodb connection handling will solve: