This repository was archived by the owner on Aug 30, 2021. It is now read-only.
Fix more typos and spruce up some grammar and wording.#315
Merged
Conversation
Closed
Member
|
Looks pretty good, but whoever merges just give this another look-over. |
Member
There was a problem hiding this comment.
"and will keep updated it" doesn't sound good.
Contributor
Author
There was a problem hiding this comment.
Indeed. I put the word in the wrong place. Fixed now.
Member
|
LGTM |
lirantal
added a commit
that referenced
this pull request
Dec 22, 2014
Fix more typos and spruce up some grammar and wording.
pdfowler
pushed a commit
to pdfowler/mean
that referenced
this pull request
Jan 19, 2016
…ubmitting added contacts iteratively with the goal of showing progress Setup pages to use the osetAddContact directive (also simplified it by removing the link fn and other BS) Added exit route for add-friends-manually from the signup flow meanjs#315: Allowed exit from add friends manually page
pdfowler
pushed a commit
to pdfowler/mean
that referenced
this pull request
Jan 19, 2016
* mobile/develop: Increase reliability of the 'close' friends state Added ng-disabled attribute to ensure contact info was added before submitting added contacts iteratively with the goal of showing progress Setup pages to use the osetAddContact directive (also simplified it by removing the link fn and other BS) Added exit route for add-friends-manually from the signup flow meanjs#315: Allowed exit from add friends manually page Kill the default values for the user's props Change contacts list display to use collection-repeat for performance reasons. Added spinner when loading contacts Eliminated the "account.profile.friends.manual" state in favor of profileModalsService.showFriendManualAddModal disable cache to fix old data after signup profile edit trailers and trucks bugfixes added on error message for request review merge with, develop. Fixed getting last my post with coordinates in activity.service added lastlocation in activity template add friends button on activity tab redirects user to friends screen Adding a top-level "AppConfig" value for 'debug' - and disable debug mode if needed (i.e.: production mode) Removing old images select contact to share documents added placeName and placeId fields to activity.location send review request Conflicts: mobile/www/modules/account/child_modules/profile/controllers/profile.controller.js mobile/www/modules/account/config/account.module.routes.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the results of a more thorough review instead of the one-offs from today and a couple days ago.