Skip to content

Remove the lxml dependency#10

Merged
garethterrace merged 1 commit intomediaburst:masterfrom
zeroSteiner:rm-lxml
Feb 24, 2016
Merged

Remove the lxml dependency#10
garethterrace merged 1 commit intomediaburst:masterfrom
zeroSteiner:rm-lxml

Conversation

@zeroSteiner
Copy link
Copy Markdown
Contributor

This pull request removes the dependency on the lxml module in favor of Python's build in xml module. The lxml module dependency unnecessarily complicates the installation process of the clockwork-python package making it more difficult to include in software distributions. This PR also adjusts white space to be more pep8 compliant.

@mattwoberts
Copy link
Copy Markdown
Contributor

Good work 👍

On Sun, 7 Feb 2016 03:36 Spencer McIntyre notifications@github.com wrote:

This pull request removes the dependency on the lxml module in favor of
Python's build in xml module. The lxml module dependency unnecessarily
complicates the installation process of the clockwork-python package making
it more difficult to include in software distributions. This PR also

adjusts white space to be more pep8 compliant.

You can view, comment on, or merge this pull request online at:

#10
Commit Summary

  • Remove the lxml dependency

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#10.

@garethterrace
Copy link
Copy Markdown
Contributor

Hey, sorry it's taken us so long to get to this - we're going to pull it in as soon as we can.

Thanks for your contribution.

@garethterrace
Copy link
Copy Markdown
Contributor

Happy with this - we've got a small unit test fix to do, but will try and release this asap.

garethterrace pushed a commit that referenced this pull request Feb 24, 2016
Remove the lxml dependency
@garethterrace garethterrace merged commit 3e9ab4c into mediaburst:master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants