Remove the lxml dependency#10
Merged
garethterrace merged 1 commit intomediaburst:masterfrom Feb 24, 2016
Merged
Conversation
Contributor
|
Good work 👍 On Sun, 7 Feb 2016 03:36 Spencer McIntyre notifications@github.com wrote:
|
Contributor
|
Hey, sorry it's taken us so long to get to this - we're going to pull it in as soon as we can. Thanks for your contribution. |
Contributor
|
Happy with this - we've got a small unit test fix to do, but will try and release this asap. |
garethterrace
pushed a commit
that referenced
this pull request
Feb 24, 2016
Remove the lxml dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the dependency on the lxml module in favor of Python's build in xml module. The lxml module dependency unnecessarily complicates the installation process of the clockwork-python package making it more difficult to include in software distributions. This PR also adjusts white space to be more pep8 compliant.