Python 3.x compatibility fixes#8
Merged
garethterrace merged 3 commits intomediaburst:masterfrom Jan 5, 2015
bjornpost:python3
Merged
Python 3.x compatibility fixes#8garethterrace merged 3 commits intomediaburst:masterfrom bjornpost:python3
garethterrace merged 3 commits intomediaburst:masterfrom
bjornpost:python3
Conversation
Contributor
Author
|
Some refactoring ideas:
|
Contributor
|
Hi Bjorn, Really appreciate the work you've put in for us here - drop us a mail at hello@clockworksms.com and we can give you some free credit as a bit of a thanks. We'll be pulling in these changes as soon as we can and the refactoring ideas we'll take a look at. Thanks again |
|
Glad I checked the PRQs before I did this myself! 👍 |
Contributor
|
Happy with this - we'll update the package as soon as possible. |
garethterrace
pushed a commit
that referenced
this pull request
Jan 5, 2015
Python 3.x compatibility fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple of things to make sure the lib runs on Python 3 (tested on 3.4.2):
import clockwork_http) have been made explicit (from . import clockwork_http)Urllib2does no longer exist in Python 3 and is split inurllib.requestandurllib.error. Fixed imports accordingly in a backward compatible way.