feat: Video Trimmer and more #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…desktop timeline issues - Fixed segment and cutaway playback to properly stop at the end and resume correctly after user interaction - Ensured playback continues seamlessly from cutaway to next segment when clicking Play - Updated start and end bracket icons for both segment and cutaway popup menus to correct designs - Fixed dynamic updates of popup menus when dragging segment boundaries past the playhead - Fixed issue where deleting a segment did not trigger correct switch to cutaway popup menu - Synced playback icons between popup menu and video controls under various playback scenarios - Replaced browser-native unload confirmation with a custom, unified message to warn about unsaved edits - Ensured timeline-based editing now works reliably on iPhone/iPad (iOS Safari) - Fixed issue where clicking at the end of a cutaway area closed the popup and prevented re-opening on desktop browsers
mgogoulos
commented
May 26, 2025
| @@ -0,0 +1,14 @@ | |||
| import { defineConfig } from "drizzle-kit"; | |||
Contributor
Author
There was a problem hiding this comment.
@Yiannistaos is this being used? If not please remove (along with package.json/yarn.lock entries)
Collaborator
There was a problem hiding this comment.
@mgogoulos You're right — this is no longer needed. I’ve removed it in the latest commit. It was used earlier as a mock database setup with Drizzle ORM before we integrated with Django.
mgogoulos
commented
May 26, 2025
| @@ -0,0 +1,17 @@ | |||
| import { pgTable, text, serial, integer, boolean } from "drizzle-orm/pg-core"; | |||
| import { createInsertSchema } from "drizzle-zod"; | |||
Contributor
Author
There was a problem hiding this comment.
@Yiannistaos i believe this is redundant too?
Collaborator
There was a problem hiding this comment.
@mgogoulos You're right — this is no longer needed. I’ve removed it in the latest commit. It was used earlier as a mock database setup with Drizzle ORM before we integrated with Django.
In Preview mode, you can jump in timeline to review the edits, without having to listen to the full video.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is pending here