Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/Layout/DNDLayout/DNDLayout.css
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
transform: translate(0, 10px);
filter: blur(1px);
}

.dndState .blockContent {
scroll-snap-type: none;
}
.DNDContent {
min-height: 100%;
display: flex;
Expand Down
8 changes: 7 additions & 1 deletion src/components/Layout/DesktopCards.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { useLayoutEffect, useRef } from 'react'
import SortableList, { SortableItem } from 'react-easy-sort'
import { SUPPORTED_CARDS } from 'src/config'
import { CustomRssCard } from 'src/features/cards'
import { useRemoteConfigStore } from 'src/features/remoteConfig'
import { trackPageDrag } from 'src/lib/analytics'
import { useUserPreferences } from 'src/stores/preferences'
import { SelectedCard, SupportedCardType } from 'src/types'
Expand All @@ -16,6 +17,7 @@ export const DesktopCards = ({
const AVAILABLE_CARDS = [...SUPPORTED_CARDS, ...userCustomCards]
const { updateCardOrder } = useUserPreferences()
const scrollHolderRef = useRef<HTMLElement | null>(null)
const { adsConfig } = useRemoteConfigStore()

const onSortEnd = (oldIndex: number, newIndex: number) => {
updateCardOrder(oldIndex, newIndex)
Expand Down Expand Up @@ -50,7 +52,11 @@ export const DesktopCards = ({
return (
<SortableItem key={card.name}>
<div>
<Component key={card.name} meta={constantCard} withAds={index === 0} />
<Component
key={card.name}
meta={constantCard}
withAds={index === adsConfig.columnPosition}
/>
</div>
</SortableItem>
)
Expand Down
28 changes: 26 additions & 2 deletions src/components/List/ListComponent.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import React, { ReactNode } from 'react'
import React, { ReactNode, useEffect } from 'react'
import { Placeholder } from 'src/components/placeholders'
import { MAX_ITEMS_PER_CARD } from 'src/config'
import { BannerAd } from 'src/features/ads'
import { useRemoteConfigStore } from 'src/features/remoteConfig'
import { BaseEntry } from 'src/types'

type PlaceholdersProps = {
Expand Down Expand Up @@ -39,6 +40,29 @@ export function ListComponent<T extends BaseEntry>(props: ListComponentPropsType
placeholder = <Placeholder />,
limit = MAX_ITEMS_PER_CARD,
} = props
const { adsConfig } = useRemoteConfigStore()
const [canAdsLoad, setCanAdsLoad] = React.useState(true)

useEffect(() => {
if (!adsConfig.enabled || !withAds) {
return
}

const handleClassChange = () => {
if (document.documentElement.classList.contains('dndState')) {
setCanAdsLoad(false)
} else {
setCanAdsLoad(true)
}
}

const observer = new MutationObserver(handleClassChange)
observer.observe(document.documentElement, { attributes: true })

return () => {
observer.disconnect()
}
}, [withAds, adsConfig.enabled])

if (error) {
return <p className="errorMsg">{error?.message || error}</p>
Expand All @@ -51,7 +75,7 @@ export function ListComponent<T extends BaseEntry>(props: ListComponentPropsType

return items.slice(0, limit).map((item, index) => {
let content: ReactNode[] = [renderItem(item, index)]
if (withAds && index === 0) {
if (canAdsLoad && adsConfig.enabled && withAds && index === adsConfig.rowPosition) {
content.unshift(<BannerAd key={'banner-ad'} />)
}
return content
Expand Down
87 changes: 51 additions & 36 deletions src/features/remoteConfig/stores/remoteConfig.ts
Original file line number Diff line number Diff line change
@@ -1,42 +1,57 @@
import { create } from 'zustand';
import { create } from 'zustand'

import { persist } from 'zustand/middleware';
import { RemoteConfig, Tag } from "../types";
import { persist } from 'zustand/middleware'
import { RemoteConfig, Tag } from '../types'

type RemoteConfigStore = {
supportedTags: Tag[];
marketingBannerConfig?: any;
setRemoteConfig: (remoteConfig: RemoteConfig) => void;
};
supportedTags: Tag[]
marketingBannerConfig?: any
adsConfig: {
rowPosition: number
columnPosition: number
enabled: boolean
}
setRemoteConfig: (remoteConfig: RemoteConfig) => void
}

export const useRemoteConfigStore = create(persist<RemoteConfigStore>((set) => ({
marketingBannerConfig: undefined,
supportedTags: [
{
value: 'javascript',
label: 'Javascript',
githubValues: ['javascript'],
confsValues: ['javascript'],
devtoValues: ['javascript'],
hashnodeValues: ['javascript'],
mediumValues: ['javascript'],
redditValues: ['javascript'],
freecodecampValues: ['javascript']
},
],
setRemoteConfig: (remoteConfig: RemoteConfig) =>
set(() => {
const { marketingBannerConfig, ...otherConfigs } = remoteConfig
return { ...otherConfigs }
export const useRemoteConfigStore = create(
persist<RemoteConfigStore>(
(set) => ({
marketingBannerConfig: undefined,
adsConfig: {
rowPosition: 0,
columnPosition: 0,
enabled: false,
},
supportedTags: [
{
value: 'javascript',
label: 'Javascript',
githubValues: ['javascript'],
confsValues: ['javascript'],
devtoValues: ['javascript'],
hashnodeValues: ['javascript'],
mediumValues: ['javascript'],
redditValues: ['javascript'],
freecodecampValues: ['javascript'],
},
],
setRemoteConfig: (remoteConfig: RemoteConfig) =>
set(() => {
const { marketingBannerConfig, ...otherConfigs } = remoteConfig
return { ...otherConfigs }
}),
}),
}), {
name: 'remote_config_storage',
version: 1,
migrate(persistedState, version) {
const newState = persistedState as RemoteConfigStore;
if (version === 0) {
delete newState.marketingBannerConfig
{
name: 'remote_config_storage',
version: 1,
migrate(persistedState, version) {
const newState = persistedState as RemoteConfigStore
if (version === 0) {
delete newState.marketingBannerConfig
}
return newState
},
}
return newState;
},
}));
)
)
7 changes: 6 additions & 1 deletion src/features/remoteConfig/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ export type TagValuesFieldType =

export type RemoteConfig = {
supportedTags: Tag[]
refresh_rate: number | false,
refresh_rate: number | false
marketingBannerConfig?: any
adsConfig: {
rowPosition: number
columnPosition: number
enabled: boolean
}
}