Skip to content

Add Phind search engine#160

Merged
medyo merged 31 commits intomedyo:developfrom
MustCodeAl:master
Sep 28, 2023
Merged

Add Phind search engine#160
medyo merged 31 commits intomedyo:developfrom
MustCodeAl:master

Conversation

@MustCodeAl
Copy link
Copy Markdown
Contributor

@MustCodeAl MustCodeAl commented Sep 3, 2023

adding phind.com

medyo and others added 27 commits February 11, 2023 13:53
@medyo
Merge pull request medyo#128 from medyo/develop
a9eae10 
new version
@medyo
Merge pull request medyo#129 from medyo/develop
61bbcd1 
change the tag github action to support hashtags commit #minor
@medyo
Merge pull request medyo#130 from medyo/develop
374cb5a 
Fix Distribution Github action
@medyo
Merge pull request medyo#131 from medyo/develop
c89e01f 
update checkout action and enable logs
@medyo
Merge pull request medyo#132 from medyo/develop
818f13b 
set full branch history
@medyo
Merge pull request medyo#133 from medyo/develop
1c1a4f6 
feat(ci):revert github tag action (demo)
@medyo
Merge pull request medyo#134 from medyo/develop
40bae44 
fix: checkout action version
@medyo
Merge pull request medyo#135 from medyo/develop
2b2e1f0 
patch: custom_release_rules
@medyo
Merge pull request medyo#136 from medyo/develop
1f337eb 
minor: add minor to custom_release_rules
@medyo
Bump manifest version
a51b972
@medyo
Merge pull request medyo#137 from medyo/develop
8cb68fb 
fix alignment issue
@medyo
Merge pull request medyo#138 from medyo/develop
0e9c341 
fix checking existing feed urls
@medyo
Merge pull request medyo#139 from medyo/develop
0940c31 
fix console warning
@medyo
Bump manifest version
c6d4b07
@medyo
Merge pull request medyo#141 from medyo/develop
f6b8755 
New version
@medyo
Bump manifest version
f4c85b2
@medyo
set --openssl-legacy-provider
44bea11
@medyo
Bump manifest version
38d2e98
@medyo
Merge pull request medyo#146 from medyo/develop
0c90f66 
New version
@medyo
Bump manifest version
8335442
@medyo
Merge pull request medyo#148 from medyo/develop
57a20b2 
implement: dnd mode
@medyo
Merge pull request medyo#149 from medyo/develop
8f7a0af 
fix the navigation item color
@medyo
Bump manifest version
93b6e15
@medyo
Merge pull request medyo#151 from medyo/develop
98d4acd 
fix ads display
@medyo
Bump manifest version
a5857c8
@MustCodeAl
Update index.tsx
8b3c535 
adding phind.com
@MustCodeAl
add phind logo
ad9e35a 
add phind logo svg
@medyo medyo self-requested a review September 5, 2023 09:14
@medyo medyo added the New feature Request a new language to add label Sep 5, 2023
@medyo medyo linked an issue Sep 5, 2023 that may be closed by this pull request
add phind.com as search engine to hacktab #158
Closed
medyo
medyo requested changes Sep 5, 2023
View reviewed changes
Copy link
Copy Markdown
Owner

@medyo medyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo should appear in white when using the Dark Mode
Can you handle it using css only. Something like

.dark .searchEngineLogo {
  fill: white;
}

image

@MustCodeAl
Update index.tsx
2220969 
updating phind to include phind-logo classname
@MustCodeAl
Update App.css
0e480e0 
to include phind logo dark css
@MustCodeAl
Update index.tsx
e3dfff5 
include phindlogo classname
@MustCodeAl
Copy link
Copy Markdown
Contributor Author

MustCodeAl commented Sep 14, 2023

is this ok to put in app.css?

.dark .phindLogo {
  fill: white;
}

@medyo
Copy link
Copy Markdown
Owner

medyo commented Sep 14, 2023

is this ok to put in app.css?

.dark .phindLogo {
  fill: white;
}

Yes, that's okay, can you rename the class to be more generic so it can be used for the Yahoo logo too as it has the same UI issue?

MustCodeAl
MustCodeAl commented Sep 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@MustCodeAl MustCodeAl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the class more generic

@medyo medyo changed the base branch from master to develop September 28, 2023 11:36
@medyo medyo changed the title Update index.tsx and assets svg to include phind Add Phind search engine Sep 28, 2023
@medyo medyo merged commit 7de744b into medyo:develop Sep 28, 2023
@medyo
Copy link
Copy Markdown
Owner

medyo commented Sep 28, 2023

Thanks @MustCodeAl for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyo medyo medyo requested changes

Assignees

No one assigned

Labels

New feature Request a new language to add

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add phind.com as search engine to hacktab

2 participants

@MustCodeAl @medyo