prevent slide CTA from disappearing on scroll#166
Merged
medyo merged 1 commit intomedyo:developfrom Sep 28, 2023
victor-duarte:fix/slide-navigation-cta-disappear
Merged
prevent slide CTA from disappearing on scroll#166medyo merged 1 commit intomedyo:developfrom victor-duarte:fix/slide-navigation-cta-disappear
medyo merged 1 commit intomedyo:developfrom
victor-duarte:fix/slide-navigation-cta-disappear
Conversation
medyo
requested changes
Sep 28, 2023
Owner
medyo
left a comment
medyo
left a comment
There was a problem hiding this comment.
Looks good, well done
can you remove the unused class scrollButtonNext?
Contributor
Author
The class has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112
Scroll event added to
.Cardsis triggered on scroll of the children (.Block) causing calculation to be done againstBlockoffset instead ofCardsreturning unexpected values..Cardselementsfalsesince the CTA's would only appear after user setupBlockbeing cutoff when scrolling is available by removing thescroll-padding-leftproperty