Skip to content

Improve the phind integration #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
medyo merged 2 commits into from
Sep 28, 2023
Merged

Improve the phind integration #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a608ac
improve the baidu logo adaptiveness
medyo Sep 28, 2023
cbf10c4
move the new class to the right file and pass classname explicitly
medyo Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/assets/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,6 @@ a {
.dark .blockHeaderWhite {
color: white;
}
.dark .SELogo {
fill: white;
}


.light .blockHeaderWhite {
color: black;
Expand Down
2 changes: 1 addition & 1 deletion src/assets/baidu_logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions src/components/Elements/SearchBarWithLogo/SearchBarWithLogo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,7 @@
width: 100%;
height: 100%;
}

.dark .searchEngineLogo .themeAdaptiveFillColor {
fill: white;
}
4 changes: 2 additions & 2 deletions src/components/Elements/SearchBarWithLogo/SearchBarWithLogo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ export const SearchBarWithLogo = () => {

return (
<div className="searchBarWithLogo">
{userSearchEngine && userSearchEngine.logo && (
{userSearchEngine?.logo && (
<div className="searchEngineLogo">
<userSearchEngine.logo />
<userSearchEngine.logo className={userSearchEngine?.className} />
</div>
)}
<SearchBar />
Expand Down
6 changes: 4 additions & 2 deletions src/config/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import { ReactComponent as DuckDuckGoLogo } from 'src/assets/duckduckgo_logo.svg
import { ReactComponent as GoogleLogo } from 'src/assets/google_logo.svg'
import HashNodeIcon from 'src/assets/icon_hashnode.png'
import LobstersIcon from 'src/assets/icon_lobsters.png'
import { ReactComponent as PhindLogo } from 'src/assets/phind_logo.svg'
import { ReactComponent as StartPageLogo } from 'src/assets/startpage_logo.svg'
import { ReactComponent as YahooLogo } from 'src/assets/yahoo_logo.svg'
import { ReactComponent as YandexLogo } from 'src/assets/yandex_logo.svg'
import { ReactComponent as PhindLogo } from 'src/assets/phind_logo.svg'

import {
ConferencesCard,
Expand Down Expand Up @@ -75,6 +75,7 @@ export const SUPPORTED_SEARCH_ENGINES = [
label: 'Yandex',
url: 'https://yandex.ru/search/?text=',
logo: YandexLogo,
className: 'themeAdaptiveFillColor',
},
{
label: 'Startpage',
Expand All @@ -84,7 +85,8 @@ export const SUPPORTED_SEARCH_ENGINES = [
{
label: 'Phind',
url: 'https://phind.com/search?q=',
logo: <PhindLogo className={"SELogo"} />,
logo: PhindLogo,
className: 'themeAdaptiveFillColor',
},
]
export const SUPPORTED_CARDS: SupportedCardType[] = [
Expand Down