Skip to content

4403 – Deprecate Uol parsers#396

Merged
vasconsaurus merged 1 commit intodevelopfrom
4403-deprecate-uol-parsers
Jun 26, 2024
Merged

4403 – Deprecate Uol parsers#396
vasconsaurus merged 1 commit intodevelopfrom
4403-deprecate-uol-parsers

Conversation

@vasconsaurus
Copy link
Contributor

Description

Uol is now using the API, so we can deprecate their parser.

References: 4403

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings

@vasconsaurus vasconsaurus marked this pull request as ready for review June 25, 2024 18:52
@vasconsaurus vasconsaurus requested a review from DGaffney June 25, 2024 18:52
@vasconsaurus vasconsaurus merged commit 3bba1f3 into develop Jun 26, 2024
@vasconsaurus vasconsaurus deleted the 4403-deprecate-uol-parsers branch June 26, 2024 14:05
vasconsaurus added a commit that referenced this pull request Jun 26, 2024
Uol and Comprova are now using the API, so we can deprecate their parser.

References: 4403
PR: 396
@vasconsaurus vasconsaurus mentioned this pull request Oct 24, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants