221: Retroactive Codex review of merged PRs #24-#28#36
Merged
Conversation
Audit deliverable for kbmd #221. PRs #24-#28 merged on main before devd PR #66 enabled adversarial Codex review by default (local scripts/devd-verify.sh stub + devd-issue.sh not passing --code-review). Ran codex review --commit <merge-sha> against each of: - #24 Eval harness + ground truth pipeline (2 high) - #25 eval/types.ts Retriever interface (clean) - #26 Python parser + import resolver (2 medium) - #27 Go parser + import resolver (2 medium) - #28 Competitor adapters (2 medium) Total: 2 high, 6 medium, 0 low. Followups filed: - kbmd #228 - Fix eval ground-truth filter to drop Changesets release PRs - kbmd #229 - refresh.sh single-repo path nukes all other eval/data - kbmd #230 - Codex retro review medium findings (PRs #26/#27/#28) No overlap with already-merged fix PRs #31 (FTS5), #32 (ranker), #33 (eval writeup). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit deliverable for kbmd #221. PRs #24-#28 landed on
mainbefore devd PR #66 enabled adversarial Codex review by default — none got reviewed at merge time. This PR commits the retro-review report.codex review --commit <merge-sha>against each PRFollowup issues filed
refresh.shsingle-repo path nukes all othereval/data(high)Test plan
bunx tsc --noEmitcleanbun test— 193 pass / 2 skip / 0 fail (run by devd-commit verify)docs/reviews/2026-05-13-retroactive-codex.mdand sanity-checks the kbmd followups existThis is a docs-only commit — no production code changed.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com